-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[cmake] only require a CXX compiler when tests are build #4357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Cyan4973 any chance that this gets merged? |
Some |
630932f
to
c3b53d3
Compare
@Cyan4973 I updated the patch, but I can't really test it properly. |
It still fails, mostly the same way. If you don't have local testing capabilities, |
3ed3935
to
cb9be97
Compare
Signed-off-by: Thomas Devoogdt <[email protected]>
I was not really able to get those runners working. But I have the feeling (or I hope so), that the third time will be the good time. |
See: facebook/zstd#4357 Signed-off-by: Thomas Devoogdt <[email protected]>
@Cyan4973 All tests are passing, can you have a look? |
@Cyan4973 Thx for the approve, who should merge this now? |
See: facebook/zstd#4357 Signed-off-by: Thomas Devoogdt <[email protected]>
@Cyan4973 Thanks! |
No description provided.