Skip to content

[cmake] only require a CXX compiler when tests are build #4357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

ThomasDevoogdt
Copy link
Contributor

No description provided.

@ThomasDevoogdt
Copy link
Contributor Author

@Cyan4973 any chance that this gets merged?

@Cyan4973
Copy link
Contributor

Some cmake tests are failing following this cmake PR.
It should be investigated.

@ThomasDevoogdt
Copy link
Contributor Author

@Cyan4973 I updated the patch, but I can't really test it properly.

@Cyan4973
Copy link
Contributor

It still fails, mostly the same way.

If you don't have local testing capabilities,
you can still enable Github Actions CI tests directly within your fork,
so that they run automatically in your fork after each commit,
thus making you autonomous from upstream test infrastructure, which features additional security constraints.

@ThomasDevoogdt ThomasDevoogdt force-pushed the bugfix/cxx branch 4 times, most recently from 3ed3935 to cb9be97 Compare May 1, 2025 13:28
@ThomasDevoogdt
Copy link
Contributor Author

It still fails, mostly the same way.

If you don't have local testing capabilities, you can still enable Github Actions CI tests directly within your fork, so that they run automatically in your fork after each commit, thus making you autonomous from upstream test infrastructure, which features additional security constraints.

I was not really able to get those runners working. But I have the feeling (or I hope so), that the third time will be the good time.

@ThomasDevoogdt
Copy link
Contributor Author

@Cyan4973 All tests are passing, can you have a look?

@ThomasDevoogdt
Copy link
Contributor Author

ThomasDevoogdt commented May 6, 2025

@Cyan4973 Thx for the approve, who should merge this now?

ThomasDevoogdt added a commit to ThomasDevoogdt/fluent-bit that referenced this pull request May 6, 2025
@Cyan4973 Cyan4973 merged commit 769723a into facebook:dev May 6, 2025
101 checks passed
@ThomasDevoogdt
Copy link
Contributor Author

@Cyan4973 Thanks!

@ThomasDevoogdt ThomasDevoogdt deleted the bugfix/cxx branch May 31, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants